Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: marionettejs/backbone.marionette
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.1
Choose a base ref
...
head repository: marionettejs/backbone.marionette
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.2
Choose a head ref
  • 8 commits
  • 17 files changed
  • 4 contributors

Commits on Jan 15, 2015

  1. Missing semicolon in marionette.application docs 

    I was following the docs and copied this code into my application. My grunt task run jshint and I noticed this error.
    @ChrisGrant
    ChrisGrant committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    e77151d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2198 from ChrisGrant/patch-1 

    Missing semicolon in marionette.application docs
    @samccone
    samccone committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    937e095 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect event name docs 

    Updated event naming in docs from "collection:rendered" -> "render:collection" along with the associated "on" version of the event (i.e. onRenderCollection vs onCollectionRendered)
Updated event naming in source comments docs from "child:added" -> "add:child"
    @ryno1234 @samccone
    ryno1234 authored and samccone committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    ccff995 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2015

  1. Revert "Documentation fix: broken link to Marionette.View" 

    This reverts commit 1ee9c53.
    @samccone
    samccone committed Jan 18, 2015
    Configuration menu
    Copy the full SHA
    18c5139 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2015

  1. Merge pull request #2210 from marionettejs/sjs/revert-doc-change 

    Revert "Documentation fix: broken link to Marionette.View"
    @samccone
    samccone committed Jan 19, 2015
    Configuration menu
    Copy the full SHA
    49904d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2015

  1. Fix misleading #bindEntitiyEvents docs

    @samccone
    David Schäfer authored and samccone committed Jan 29, 2015
    Configuration menu
    Copy the full SHA
    2478c5d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2015

  1. Ensure apply is not called with undefined. 

    Fixes a bug in IE8
Fixes #2225
    @samccone
    samccone committed Jan 30, 2015
    2 Configuration menu
    Copy the full SHA
    be6f1b4 View commit details
    Browse the repository at this point in the history

  2. v2.3.2 bump and build

    @samccone
    samccone committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    51f2876 View commit details
    Browse the repository at this point in the history
Loading