Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ui file to MVP file generator #38095

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add .ui file to MVP file generator #38095

wants to merge 4 commits into from

Conversation

adriazalvarez
Copy link
Contributor

Description of work

This PR slightly modifies the way to generate the GUI used in the MVP generation tool #37813 to work with .ui files, which is a more common way to operate with GUIs in Mantid.

Summary of work

This PR adds a .ui file that generates a simple qt widget (same as the one generated programatically in #37813).
Additionally, I have modified the corresponding view files and cmake files as well as the template.py generator function to account for the inclusion of the .ui file

Fixes #37977

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@adriazalvarez adriazalvarez added the GUI Issues and pull requests specific to the Mantid Workbench GUI. label Sep 27, 2024
@adriazalvarez adriazalvarez added this to the Release 6.12 milestone Sep 27, 2024
@adriazalvarez adriazalvarez marked this pull request as ready for review September 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues and pull requests specific to the Mantid Workbench GUI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .ui file to the MVP creation tool.
1 participant