Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate OutputPlotOptionsPresenter::replaceHandle logic #38097

Open
MohamedAlmaki opened this issue Sep 27, 2024 · 0 comments
Open

Investigate OutputPlotOptionsPresenter::replaceHandle logic #38097

MohamedAlmaki opened this issue Sep 27, 2024 · 0 comments
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic Investigation A task to investigate options for future work Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 6.12

Comments

@MohamedAlmaki
Copy link
Contributor

MohamedAlmaki commented Sep 27, 2024 •
edited
Loading

The replaceHandle in OutputPlotOptions listens for replace events from the ADS and currently calls handleWorkspaceChanged with the same name as the workspace. We need to investigate whether this is the correct behavior or if it needs to be refactored. This logic has caused a potential race condition when updating the indices of the plot options in #38078. The issue has been resolved by disabling ADS events in #38078
@MohamedAlmaki MohamedAlmaki added Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. Investigation A task to investigate options for future work labels Sep 27, 2024
@MohamedAlmaki MohamedAlmaki added this to the Release 6.12 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic Investigation A task to investigate options for future work Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
ISIS Spectroscopy
Status: No status
Milestone
Release 6.12
Development

No branches or pull requests
1 participant
@MohamedAlmaki