Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TypeScript typings for escalade/sync #5

Closed
NMinhNguyen opened this issue Sep 14, 2020 · 3 comments
Closed

Missing TypeScript typings for escalade/sync #5

NMinhNguyen opened this issue Sep 14, 2020 · 3 comments

Comments

@NMinhNguyen
Copy link
Contributor

Hey @lukeed! Many thanks for this great package 🙂. I wanted to use escalade/sync in my TypeScript project but it appears that there's no types for the synchronous API. I'm not sure how the types are currently being generated, but presumably we'd need to point bundt at the synchronous entry point as well?

@NMinhNguyen
Copy link
Contributor Author

Hm, actually I just noticed that there are types for escalade/sync (https://unpkg.com/browse/[email protected]/index.d.ts) so maybe what's happening is that when I import escalade/sync, then it doesn't use this index.d.ts file and thus it can't resolve the types?

@lukeed
Copy link
Owner

lukeed commented Sep 14, 2020

Hey, thanks :)

You're right, importing into the sub-module bypasses the index.d.ts entirely. It works fine if you (or something else in your chain) imports escalade so that the definitions get loaded. This was solved by 283b571 but I never published an update. Will do so now.

@lukeed
Copy link
Owner

lukeed commented Sep 14, 2020

Available in v3.1.0
Thanks for the reminder~!

@lukeed lukeed closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants