Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightbend-labs/scala-logging
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: lucidsoftware/scala-logging
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 27 files changed
  • 1 contributor

Commits on Oct 6, 2023

  1. Add support for scala 2/3 compatible macros 

    A lot of things were removed that the original scala-logging repo was leveraging heavily:
- Build/deploy definitions (these can easily be restored)
- LoggerTakingImplicits (couldn't get the version-unifying project to build with implicits being involved in the macros for some reason)
- Scala 2.11 and 2.12 support (cross-version macro support is limited to very specific versions of Scala 2.13 and Scala 3)

This commit represents the beginning of the Lucid Software branch of the scala-logging library. Due to the major changes, it should never be merged back into the scala-logging library, but it can serve as a starting point for those interested in attempting to bridge the compatibility gap between this library and Scala 2 + 3 in a less destructive way.
    @srollins-lucid
    srollins-lucid committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a5e76ba View commit details
    Browse the repository at this point in the history

  2. Don't run tests against scala 2.11 or scala 2.12 

    Definitely don't merge this into the upstream repo!
    @srollins-lucid
    srollins-lucid committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9752b28 View commit details
    Browse the repository at this point in the history
Loading