Video download #34
Merged
Video download #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When image overrides are turned off, the check of an existing file should be done before getting the available image sizes from Flickr. This avoids unnecessary Flickr accesses and speeds up the process.
If an error occurs during downloading an image from a set, a warning instead of an error is emitted. This allows the rest of the set being downloaded.
Photos that list the value "Video Original" as an available size are threated as videos. The download url of them has to be extracted from one the video sizes (e.g. "Video Original", "HD MP4", "Mobile MP4", "Site MP4", etc.). Otherwise, the video's thumbnail is fetched. Moreover, the file extension is adjusted to "mp4".
|
Great addition :) Thanks @saemy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Photos that list the value "Video Original" as an available size are threated as videos. The download url of them has to be extracted from one the video sizes (e.g. "Video Original", "HD MP4", "Mobile MP4", "Site MP4", etc.). Otherwise, the video's thumbnail is fetched. Moreover, the file extension is adjusted to "mp4".