Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup & completion of download on errors. #30

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Speedup & completion of download on errors. #30

merged 2 commits into from
Aug 5, 2016

Conversation

saemy
Copy link
Contributor

@saemy saemy commented Aug 4, 2016

  1. When overwriting of files is turned off, the check if the file already exists should be moved before getting the available sizes of the image from Flickr. This highly speeds up the download process on repeated downloads.
  2. Errors occuring while downloading an image should not abort the entire process of getting the whole set.

@saemy
Avoids unnecessary Flickr accesses.
1d11103 
When image overrides are turned off, the check of an existing file should be
done before getting the available image sizes from Flickr. This avoids
unnecessary Flickr accesses and speeds up the process.
@saemy
Replaces errors by warnings during image download.
7fe79d4 
If an error occurs during downloading an image from a set, a warning instead of
an error is emitted. This allows the rest of the set being downloaded.
@coveralls
Copy link

coveralls commented Aug 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.3%) to 92.818% when pulling 7fe79d4 on saemy:master into bfb8abf on lmammino:master.

@lmammino
Copy link
Owner

lmammino commented Aug 5, 2016

Thanks for the support @saemy ! Looks great

@lmammino lmammino merged commit 1dfe55c into lmammino:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saemy @coveralls @lmammino