Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set sendTo to remote peer id in trace events #268

Merged
merged 1 commit into from
Mar 16, 2020
Merged

set sendTo to remote peer id in trace events #268

merged 1 commit into from
Mar 16, 2020

Conversation

yusefnapora
Copy link
Contributor

I noticed as I was playing with the tracer output that the sendTo field for SendRPC and DropRPC trace events was always missing.

This changes the SendRPC and DropRPC tracer methods to use the remote peer id instead of rpc.from.

@yusefnapora yusefnapora requested a review from vyzo March 16, 2020 14:14
@vyzo vyzo merged commit fe350fd into master Mar 16, 2020
@vyzo vyzo mentioned this pull request Mar 16, 2020
Merged
7 tasks
@vyzo vyzo deleted the fix-tracer-sendTo-field branch April 20, 2020 21:00
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yusefnapora @vyzo