Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tabindex when slider is disabled #1227

Closed
mitar opened this issue Sep 23, 2022 · 3 comments
Closed

Disable tabindex when slider is disabled #1227

mitar opened this issue Sep 23, 2022 · 3 comments
Labels
Bug Confirmed bugs

Comments

@mitar
Copy link

mitar commented Sep 23, 2022

When I call slider.setAttribute('disabled', true), I can still focus handles (but I cannot move them, as expected). Ideally, they would not be focusable anymore. Sadly, keyboardSupport is not among options which I could update to do this manually, either, when disabling the slider.

@mitar
Copy link
Author

mitar commented Sep 23, 2022

Sadly manually disabling by doing:

  for (const handle of slider.querySelectorAll(".noUi-handle")) {
    handle.setAttribute("tabindex", -1)
  }

does not work for me because handles are not always already created at the time I might want to disable slider.

@leongersen leongersen added the Bug Confirmed bugs label Dec 14, 2022
@leongersen
Copy link
Owner

In 15.7.0, there are now API methods to enable/disable a slider. This also takes care of the tabindex on handles.

Thanks for contributing!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants