prepare 7.4.1 release

ldclient/integrations/test_data.py

@@ -204,7 +204,7 @@ def fallthrough_variation(self, variation):
         :return: the flag builder
         """
         if isinstance(variation, bool):
-            self._boolean_flag(self)._fallthrough_variation = variation
+            self.boolean_flag()._fallthrough_variation = _variation_for_boolean(variation)
             return self
         else:
             self._fallthrough_variation = variation
@@ -222,7 +222,7 @@ def off_variation(self, variation) :
         :return: the flag builder
         """
         if isinstance(variation, bool):
-            self._boolean_flag(self)._off_variation = variation
+            self.boolean_flag()._off_variation = _variation_for_boolean(variation)
             return self
         else:
             self._off_variation = variation
@@ -267,7 +267,7 @@ def variations(self, *variations):
 
         **Example:** Multiple variations
 
-        ::        
+        ::
             td.flag('new-flag') \
               .variations('red', 'green', 'blue')
 
@@ -297,6 +297,20 @@ def variation_for_all_users(self, variation):
         else:
             return self.clear_rules().clear_targets().on(True).fallthrough_variation(variation)
 
+    def value_for_all_users(self, value):
+        """
+        Sets the flag to always return the specified variation value for all users.
+
+        The value may be of any JSON type. This method changes the flag to have only
+        a single variation, which is this value, and to return the same variation
+        regardless of whether targeting is on or off. Any existing targets or rules
+        are removed.
+
+        :param value the desired value to be returned for all users
+        :return the flag builder
+        """
+        return self.variations(value).variation_for_all_users(0)
+
     def variation_for_user(self, user_key, variation):
         """Sets the flag to return the specified variation for a specific user key when targeting
         is on.

testing/test_test_data_source.py

@@ -164,13 +164,21 @@ def test_flagbuilder_can_set_fallthrough_variation():
 
     assert flag.build(0)['fallthrough'] == {'variation': 2}
 
+    flag.fallthrough_variation(True)
+
+    assert flag.build(0)['fallthrough'] == {'variation': 0}
+
 def test_flagbuilder_can_set_off_variation():
     td = TestData.data_source()
     flag = td.flag('test-flag')
     flag.off_variation(2)
 
     assert flag.build(0)['offVariation'] == 2
 
+    flag.off_variation(True)
+
+    assert flag.build(0)['offVariation'] == 0
+
 def test_flagbuilder_can_make_boolean_flag():
     td = TestData.data_source()
     flag = td.flag('boolean-flag').boolean_flag()
@@ -243,6 +251,22 @@ def test_flagbuilder_can_set_numerical_variation_for_user():
     ]
     assert flag.build(1)['targets'] == expected_targets
 
+def test_flagbuilder_can_set_value_for_all_users():
+    td = TestData.data_source()
+    flag = td.flag('user-value-flag')
+    flag.variation_for_user('john', 1)
+
+    built_flag = flag.build(0)
+    assert built_flag['targets'] == [{'values': ['john'], 'variation': 1}]
+    assert built_flag['variations'] == [True, False]
+
+    flag.value_for_all_users('yes')
+
+    built_flag2 = flag.build(0)
+    assert built_flag2['targets'] == []
+    assert built_flag2['variations'] == ['yes']
+
+
 def test_flagbuilder_can_build():
     td = TestData.data_source()
     flag = td.flag('some-flag')