This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Enable Ledger Hardware Wallet support for Akroma (AKA) #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch - thanks mike |
|
Looks nice, did you tested on your local environment? |
detroitpro Today at 11:12 AM @mk - can you please change this line, you are correct that RED is way too RED. @brand-akroma: #AA0087;
|
Tested locally in chrome: |
gamalielhere
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor details were left out of the Akroma PR #1976 for the Ledger. This takes care of those - please merge.
Ledger Support
Full 32bit Chain ID support: (merged)
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
Official Ledger Akroma app PR: (merged)
LedgerHQ/app-ethereum#19
Akroma is on LedgerHQ official roadmap:
https://trello.com/c/TbLAr4Ik/113-akroma-support
cc: @detroitpro