-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): bump logging and metrics dependencies #3641
chore(*): bump logging and metrics dependencies #3641
Conversation
Update to the latest versions all logging/metrics dependencies, which are part of generated manifests via `kumactl install logging` and `kumactl install metrics`, like grafana, prometheus or loki Updating loki involved some more complex changes related to non backward compatible changes in the newest version Signed-off-by: Bart Smykla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3641 +/- ##
==========================================
+ Coverage 51.11% 51.13% +0.02%
==========================================
Files 925 925
Lines 56288 56288
==========================================
+ Hits 28773 28785 +12
+ Misses 25231 25214 -17
- Partials 2284 2289 +5
Continue to review full report at Codecov.
|
Signed-off-by: Bart Smykla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've checked it still works on k8s LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the one change in the loki
chart, but is this just updating the image tags or does this also include the newest changes from the upstream of the charts we vendored here at some point in the past?
I'm not sure I understand your question. About |
I'm assuming we didn't write all these resources ourselves. We took them from somewhere, like the official prometheus helm chart. I think we should check those upstreams for resource changes as well. |
Summary
Update to the latest versions all logging/metrics dependencies,
which are part of generated manifests via
kumactl install logging
and
kumactl install metrics
, like grafana, prometheus or lokiUpdating loki involved some more complex changes related to non
backward compatible changes in the newest version
Full changelog
no changelog
Issues resolved
Closes #3409
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy