Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): bump logging and metrics dependencies #3641

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

bartsmykla
Copy link
Contributor

Summary

Update to the latest versions all logging/metrics dependencies,
which are part of generated manifests via kumactl install logging
and kumactl install metrics, like grafana, prometheus or loki

Updating loki involved some more complex changes related to non
backward compatible changes in the newest version

Full changelog

no changelog

Issues resolved

Closes #3409

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Update to the latest versions all logging/metrics dependencies,
which are part of generated manifests via `kumactl install logging`
and `kumactl install metrics`, like grafana, prometheus or loki

Updating loki involved some more complex changes related to non
backward compatible changes in the newest version

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested a review from a team as a code owner January 4, 2022 13:17
@codecov-commenter
Copy link

Codecov Report

Merging #3641 (f67ccb2) into master (4ffa446) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3641      +/-   ##
==========================================
+ Coverage   51.11%   51.13%   +0.02%     
==========================================
  Files         925      925              
  Lines       56288    56288              
==========================================
+ Hits        28773    28785      +12     
+ Misses      25231    25214      -17     
- Partials     2284     2289       +5     
Impacted Files Coverage Δ
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (-2.13%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 85.86% <0.00%> (-1.09%) ⬇️
pkg/insights/resyncer.go 73.61% <0.00%> (+2.45%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (+2.59%) ⬆️
pkg/test/matchers/golden.go 60.41% <0.00%> (+6.25%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffa446...f67ccb2. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've checked it still works on k8s LGTM

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the one change in the loki chart, but is this just updating the image tags or does this also include the newest changes from the upstream of the charts we vendored here at some point in the past?

@bartsmykla
Copy link
Contributor Author

I see the one change in the loki chart, but is this just updating the image tags or does this also include the newest changes from the upstream of the charts we vendored here at some point in the past?

I'm not sure I understand your question. About loki, the changes I made are also in base64 encoded configuration and are in line with the upgrade guide for v2.4.0

@bartsmykla bartsmykla merged commit fe4a41c into master Jan 5, 2022
@bartsmykla bartsmykla deleted the chore/bump-metrics-and-logging-dependencies branch January 5, 2022 13:30
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Jan 5, 2022

I see the one change in the loki chart, but is this just updating the image tags or does this also include the newest changes from the upstream of the charts we vendored here at some point in the past?

I'm not sure I understand your question. About loki, the changes I made are also in base64 encoded configuration and are in line with the upgrade guide for v2.4.0

I'm assuming we didn't write all these resources ourselves. We took them from somewhere, like the official prometheus helm chart. I think we should check those upstreams for resource changes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update embedded helm charts
4 participants