Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools/releases/helm.sh): don't release Gateway-related CRDs #3571

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 17, 2021

Summary

We don't want to release these CRDs yet. There are also some parts of the RBAC resources that exist because of Gateway stuff which we could also remove, perhaps via a Helm value + templates but that's less crucial.

Closes #3475

@codecov-commenter
Copy link

Codecov Report

Merging #3571 (418917a) into master (2efb5d9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3571   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files         917      917           
  Lines       55563    55563           
=======================================
+ Hits        28649    28651    +2     
+ Misses      24634    24625    -9     
- Partials     2280     2287    +7     
Impacted Files Coverage Δ
pkg/test/grpc/clientstream.go 84.00% <0.00%> (-8.00%) ⬇️
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/kds/client/sink.go 54.05% <0.00%> (-5.41%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (-2.13%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 86.95% <0.00%> (+1.08%) ⬆️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/dns/vips_allocator.go 73.75% <0.00%> (+1.41%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efb5d9...418917a. Read the comment docs.

@michaelbeaumont michaelbeaumont marked this pull request as ready for review December 21, 2021 17:54
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 21, 2021 17:54
@michaelbeaumont michaelbeaumont changed the title chore(helm): don't release Gateway-related CRDs chore(tools/releases/helm.sh): don't release Gateway-related CRDs Dec 21, 2021
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 21, 2021 17:58
tools/releases/helm.sh Outdated Show resolved Hide resolved
tools/releases/helm.sh Outdated Show resolved Hide resolved
@michaelbeaumont michaelbeaumont merged commit a266f83 into kumahq:master Dec 23, 2021
@michaelbeaumont michaelbeaumont deleted the fix/helm_no_gateway branch December 23, 2021 12:02
parkanzky pushed a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't install experimental Gateway CRDs with published Helm chart
3 participants