feat(gateway): watch Gateway for tag changes in GatewayInstance reconciler

[michaelbeaumont]

Summary

Closes #3509

[codecov-commenter]

Codecov Report

Merging #3570 (14b924a) into master (2efb5d9) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3570      +/-   ##
==========================================
+ Coverage   51.56%   51.57%   +0.01%     
==========================================
  Files         917      917              
  Lines       55563    55571       +8     
==========================================
+ Hits        28649    28661      +12     
+ Misses      24634    24625       -9     
- Partials     2280     2285       +5     

Impacted Files	Coverage Δ
...ime/k8s/controllers/gateway_instance_controller.go	0.00% <0.00%> (ø)
pkg/plugins/runtime/k8s/plugin_gateway.go	0.00% <0.00%> (ø)
pkg/plugins/leader/postgres/leader_elector.go	93.61% <0.00%> (-6.39%)	⬇️
pkg/xds/generator/direct_access_proxy_generator.go	86.95% <0.00%> (+1.08%)	⬆️
pkg/core/resources/model/rest/resource.go	69.23% <0.00%> (+1.28%)	⬆️
pkg/insights/resyncer.go	73.61% <0.00%> (+2.45%)	⬆️
pkg/events/eventbus.go	92.59% <0.00%> (+7.40%)	⬆️
pkg/insights/components.go	100.00% <0.00%> (+30.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efb5d9...14b924a. Read the comment docs.

[jpeach]

I think that the commit and PR message buries the lede a bit. AFAICT the main change here is to watch gateways so that we reconcile the GatewayInstance when a binding could be made. Publishing whether there is a binding is a secondary benefit.

[michaelbeaumont]

I think that the commit and PR message buries the lede a bit. AFAICT the main change here is to watch gateways so that we reconcile the GatewayInstance when a binding could be made. Publishing whether there is a binding is a secondary benefit.

Definitely, that's because the requeuing change came second, after I realized it'd never be requeued. I'll update.

[jpeach]

Nice one. LGTM.