Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): don't reset status when reconciling #3470

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 10, 2021

Remove the call to Get which resets the previous updateStatus

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 10, 2021 02:27
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 10, 2021 02:28
@codecov-commenter
Copy link

Codecov Report

Merging #3470 (e6737f3) into master (7f31204) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3470      +/-   ##
==========================================
- Coverage   51.92%   51.92%   -0.01%     
==========================================
  Files         946      946              
  Lines       54867    54865       -2     
==========================================
- Hits        28492    28489       -3     
+ Misses      24154    24153       -1     
- Partials     2221     2223       +2     
Impacted Files Coverage Δ
...e/k8s/controllers/gatewayapi/gateway_controller.go 0.00% <ø> (ø)
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f31204...e6737f3. Read the comment docs.

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the change in the commit message?

@michaelbeaumont michaelbeaumont merged commit c9fa842 into kumahq:master Dec 10, 2021
@michaelbeaumont michaelbeaumont deleted the fix/gateway_status branch December 10, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants