Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable commitlint footer rules #3407

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

The specifics of the footer aren't super important for us.

The specifics of the footer aren't super important for us.

Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 1, 2021 13:34
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 1, 2021 13:39
@codecov-commenter
Copy link

Codecov Report

Merging #3407 (f906d0b) into master (d26eb3a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
+ Coverage   52.17%   52.19%   +0.01%     
==========================================
  Files         940      940              
  Lines       54668    54668              
==========================================
+ Hits        28525    28532       +7     
+ Misses      23925    23914      -11     
- Partials     2218     2222       +4     
Impacted Files Coverage Δ
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/defaults/components.go 87.75% <0.00%> (-4.09%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (ø)
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/insights/resyncer.go 69.89% <0.00%> (+2.67%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26eb3a...f906d0b. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit ee3bed1 into kumahq:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants