Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UPGRADE.md) add note to PR template #3358

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

michaelbeaumont
Copy link
Contributor

Summary

This document should be kept up to date rather than updated before a release.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 25, 2021 00:47
@codecov-commenter
Copy link

Codecov Report

Merging #3358 (225ca08) into master (9a7dc1e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
- Coverage   52.25%   52.24%   -0.01%     
==========================================
  Files         929      929              
  Lines       54421    54421              
==========================================
- Hits        28437    28433       -4     
- Misses      23758    23760       +2     
- Partials     2226     2228       +2     
Impacted Files Coverage Δ
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-6.39%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-5.13%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7dc1e...225ca08. Read the comment docs.

@lahabana
Copy link
Contributor

Please fix the format of the PR btw

@michaelbeaumont michaelbeaumont changed the title docs: add note to PR template about UPGRADE.md docs(UPGRADE.md) add note to PR template Nov 25, 2021
@michaelbeaumont michaelbeaumont merged commit 16f0848 into kumahq:master Nov 25, 2021
@michaelbeaumont michaelbeaumont deleted the docs/upgrade branch November 25, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants