Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshexternalservice): remove unix support #11350

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 9, 2024

closes #11132

It's in experimental until 2.9 so we're ok to remove it.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka requested a review from a team as a code owner September 9, 2024 13:43
@slonka slonka requested review from jakubdyszkiewicz, Icarus9913 and lukidzi and removed request for a team September 9, 2024 13:43
@slonka slonka changed the title feat(meshexternalservice): remove unix support from mes feat(meshexternalservice): remove unix support Sep 10, 2024
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Sep 10, 2024
@slonka slonka merged commit 6239007 into kumahq:master Sep 10, 2024
11 checks passed
@slonka slonka deleted the remove-unix-support-from-mes branch September 10, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate UnixDomainPath in MeshExternalService
3 participants