Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshmultizoneservice): require ports #10984

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jul 25, 2024

Checklist prior to review

Move ports to Spec, require users to put ports, remove computing ports automatically.
The decision was made here https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/059-sni-in-the-resource.md

Fix #10982

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 25, 2024 12:01
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen and lukidzi and removed request for a team July 25, 2024 12:01
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 52c4076 into kumahq:master Jul 26, 2024
15 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/meshmzs-require-ports branch July 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require ports on MeshMultiZoneService
2 participants