Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add meshexternalservice TargetRefKind and changed int to Port #10444

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jun 12, 2024

Checklist prior to review

  • changed port type from int to Port
  • added new TargetRefKind: MeshExternalService
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: feat(MeshExternalService): implement a new resource

@lukidzi lukidzi requested a review from a team as a code owner June 12, 2024 07:55
@lukidzi lukidzi requested review from jakubdyszkiewicz, Automaat and slonka and removed request for a team June 12, 2024 07:55
Signed-off-by: Lukasz Dziedziak <[email protected]>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this also brings MeshExternalService kind

@lukidzi lukidzi changed the title feat(api): add meshexternalservice and change int to Port feat(api): add meshexternalservice TargetRefKind and changed int to Port Jun 12, 2024
@lukidzi lukidzi merged commit aab380b into kumahq:master Jun 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants