Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s API to create Gateway-related objects in Gateway controllers. #3517

Closed
Tracked by #3445
michaelbeaumont opened this issue Dec 15, 2021 · 3 comments · Fixed by #3655
Closed
Tracked by #3445

Use k8s API to create Gateway-related objects in Gateway controllers. #3517

michaelbeaumont opened this issue Dec 15, 2021 · 3 comments · Fixed by #3655
Assignees
Labels
area/gateway Built-in Kuma gateway support area/k8s kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Dec 15, 2021

Description

The foundation for this was added in #3610

@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature area/gateway Built-in Kuma gateway support labels Dec 15, 2021
@jpeach
Copy link
Contributor

jpeach commented Dec 16, 2021

I looked at the Gateway API controller as part of the change to switch Kuma Gateway resources from namespaced to cluster scoped. Just a note to remind us that in the controller, the code that calls K8sNamespacedNameToCoreName() will change as part of this issue, and we ought to use GenerateName to create the name of the Kuma Gateway resource that will be owned by the gateway API resources.

@michaelbeaumont michaelbeaumont self-assigned this Dec 17, 2021
@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Dec 17, 2021

@jpeach Now that kuma Gateway resources are cluster-scoped, they can no longer be owned by the namespace-scoped Gateway API objects. Maybe we can just annotate the Gateway/GatewayRoute objects with the namespace/name/uid of the Gateway/HTTPRoute and garbage collect them ourselves.

@jpeach
Copy link
Contributor

jpeach commented Dec 21, 2021

@jpeach Now that kuma Gateway resources are cluster-scoped, they can no longer be owned by the namespace-scoped Gateway API objects. Maybe we can just annotate the Gateway/GatewayRoute objects with the namespace/name/uid of the Gateway/HTTPRoute and garbage collect them ourselves.

Ouch, that's unfortunate. Yeh, I don't see an alternative other than doing our own garbage collection when gateway API objects are deleted. We should annotate the objects in both directions so that we can clean up from either end if we need to.

@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway Built-in Kuma gateway support area/k8s kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
2 participants