Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 deprecate MachineDeployment.Spec.Paused #8709

Closed
wants to merge 1 commit into from
Closed

🌱 deprecate MachineDeployment.Spec.Paused #8709

wants to merge 1 commit into from

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR deprecated the MachineDeployment.Spec.Paused field.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8629

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label May 20, 2023
@ykakarap
Copy link
Contributor Author

Should we also change the MachineDeployment controller to not act on the .spec.paused field? Or should that wait till the field is dropped?

@killianmuldoon
Copy link
Contributor

Should we also change the MachineDeployment controller to not act on the .spec.paused field? Or should that wait till the field is dropped?

IMO this shouldn't happen until the field is dropped.

killianmuldoon
killianmuldoon reviewed May 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area machinedeployment

@k8s-ci-robot k8s-ci-robot added the area/machinedeployment Issues or PRs related to machinedeployments label May 21, 2023
@ykakarap
Copy link
Contributor Author

ykakarap commented May 22, 2023 •
edited
Loading

/hold

Waiting for a couple of days while we get feedback from the community on the mailing list.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2023
@stmcginnis
Copy link
Contributor

/lgtm

Waiting for a couple of days while we get feedback from the community on the mailing list.

I haven't noticed - did we get any feedback on this?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb2dd65423b30eb2323b4fa4140ad5e54f1cc0e5

@sbueringer
Copy link
Member

/lgtm

Waiting for a couple of days while we get feedback from the community on the mailing list.

I haven't noticed - did we get any feedback on this?

Yup on the issue: #8629

@fabriziopandini
Copy link
Member

@ykakarap wdyt about limiting this PR to the field deprecation, so we get the process without actually changing anything?

@sbueringer
Copy link
Member

@ykakarap wdyt about limiting this PR to the field deprecation, so we get the process without actually changing anything?

Given the discussion on the issue. I'm not sure if we have consensus on the deprecation. This seems the bigger blocker to me.

@ykakarap
Copy link
Contributor Author

ykakarap commented Jun 23, 2023 •
edited
Loading

@ykakarap wdyt about limiting this PR to the field deprecation, so we get the process without actually changing anything?

I am fine with that. I can split this into 2 PRs if it helps with the process.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024
@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-blocking-main 3498f49 link true /test pull-cluster-api-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 25, 2024
@sbueringer
Copy link
Member

/close

Given ongoing discussion on the issue & that the PR needs a rebase anyway.

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close

Given ongoing discussion on the issue & that the PR needs a rebase anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@stmcginnis stmcginnis

Labels
area/clusterctl Issues or PRs related to clusterctl area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting md.spec.paused to true should fully pause the MachineDeployment
7 participants
@ykakarap @k8s-ci-robot @killianmuldoon @stmcginnis @sbueringer @fabriziopandini @k8s-triage-robot