Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

🔧 entities index #191

Merged
merged 2 commits into from
Sep 6, 2023
Merged

🔧 entities index #191

merged 2 commits into from
Sep 6, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 5, 2023 •
edited
Loading

PR type

  • Bugfix

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

⚠️ I've removed await db.query(`ALTER TABLE "collection_entity" ALTER COLUMN "owner_count" SET DEFAULT '0'`) from migration file

Screenshot

Capture d’écran 2023-09-05 à 4 39 40 PM

@roiLeo roiLeo marked this pull request as ready for review September 5, 2023 14:40
@vikiival vikiival merged commit 4d33744 into kodadot:main Sep 6, 2023
1 check passed
@vikiival
Copy link
Member

vikiival commented Sep 6, 2023

So can we repeat the process for stick?

@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 6, 2023

So can we repeat the process for stick?

partially blocked by kodadot/stick#96, i'll give it a try

@vikiival
Copy link
Member

vikiival commented Sep 6, 2023

partially blocked by kodadot/stick#96, i'll give it a try

https://github.com/casey/just

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Loligo#47] Add indexes to sort fields
2 participants
@roiLeo @vikiival