generate version.h (fixes some of the travis builds failures) #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkm000
previously requested changes
Aug 17, 2017
jtrmal
force-pushed
the
travis_version_fix
branch
from
e988388
to
4773e71
Compare
|
all right, removed and squashed. |
|
Thanks, and sorry about unintended consequences! |
|
We could consider moving to a paid option on travis, which it seems are
available now.
…On Thu, Aug 17, 2017 at 1:08 PM, Kirill Katsnelson ***@***.*** > wrote:
Thanks, and sorry about unintended consequences!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1827 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJVuxcK4MaM_ciFLy27Gd846ACgK0bAks5sZJ3FgaJpZM4O6rFF>
.
|
|
sorry posted too soon.
Here
https://travis-ci.com/plans
are plans, the "small teams" one is $129 per month. Since we paid $4k this
month for the Google cloud hosting of openslr and kaldi-asr.org (although
we're negotiating to get this down), I guess this would just a rounding
error.
…On Thu, Aug 17, 2017 at 1:11 PM, Daniel Povey ***@***.***> wrote:
We could consider moving to a paid option on travis, which it seems are
available now.
On Thu, Aug 17, 2017 at 1:08 PM, Kirill Katsnelson <
***@***.***> wrote:
> Thanks, and sorry about unintended consequences!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1827 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADJVuxcK4MaM_ciFLy27Gd846ACgK0bAks5sZJ3FgaJpZM4O6rFF>
> .
>
|
|
I have no idea why the travis failed now. |
|
ready to merge? |
|
merge yourself if ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should address issue found in #1716