-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make metric.getName()
into metric.name
#2076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 72.15% 72.12% -0.04%
==========================================
Files 181 181
Lines 14283 14289 +6
==========================================
Hits 10306 10306
- Misses 3351 3355 +4
- Partials 626 628 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
metric.getName()
into metric.name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though please squash when/before merging
The original change was proposed in #2053 and implemented in #2058