Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metric.getName() into metric.name #2076

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Make metric.getName() into metric.name #2076

merged 3 commits into from
Jun 25, 2021

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jun 25, 2021

The original change was proposed in #2053 and implemented in #2058

@mstoykov mstoykov added this to the v0.33.0 milestone Jun 25, 2021
na--
na-- previously approved these changes Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #2076 (d19c491) into master (2039c56) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head d19c491 differs from pull request most recent head 20c22d9. Consider uploading reports for the commit 20c22d9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   72.15%   72.12%   -0.04%     
==========================================
  Files         181      181              
  Lines       14283    14289       +6     
==========================================
  Hits        10306    10306              
- Misses       3351     3355       +4     
- Partials      626      628       +2     
Flag Coverage Δ
ubuntu 72.08% <50.00%> (+0.01%) ⬆️
windows 71.75% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/metrics/metrics.go 81.81% <50.00%> (-10.78%) ⬇️
lib/executor/vu_handle.go 94.39% <0.00%> (-0.94%) ⬇️
js/runner.go 81.86% <0.00%> (-0.54%) ⬇️
lib/netext/httpext/request.go 93.93% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2039c56...20c22d9. Read the comment docs.

@na-- na-- changed the title Make metric.GetName into metric.name Make metric.getName() into metric.name Jun 25, 2021
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though please squash when/before merging

@mstoykov mstoykov merged commit b232e97 into master Jun 25, 2021
@mstoykov mstoykov deleted the redoMetricName branch June 25, 2021 13:19
imiric pushed a commit to grafana/k6-docs that referenced this pull request Jun 29, 2021
imiric pushed a commit to grafana/k6-docs that referenced this pull request Jun 29, 2021
imiric pushed a commit to grafana/k6-docs that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants