Fix unlikely data race when calling BaseExecutor methods #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling these methods defined on a value receiver copies the BaseExecutor instance and could cause a data race if another goroutine is writing to it. In practice this wasn't a problem and unlikely anyone would ever run into it on master, but it did appear on the feat/1320-execution-api branch (#1863) when running: go run -race main.go run --quiet -u 5 -i 5 'github.com/k6io/k6/samples/http_get.js' Clipped stack trace: WARNING: DATA RACE Write at 0x00c00050d7a8 by main goroutine: go.k6.io/k6/lib/executor.(*SharedIterations).Init() /home/ivan/Projects/k6io/k6/lib/executor/shared_iterations.go:179 +0x384 go.k6.io/k6/core/local.(*ExecutionScheduler).Init() /home/ivan/Projects/k6io/k6/core/local/local.go:276 +0xc1c go.k6.io/k6/core.(*Engine).Init() /home/ivan/Projects/k6io/k6/core/engine.go:190 +0x148 go.k6.io/k6/cmd.getRunCmd.func1() /home/ivan/Projects/k6io/k6/cmd/run.go:248 +0x1ad7 ... Previous read at 0x00c00050d7a8 by goroutine 32: go.k6.io/k6/lib/executor.(*SharedIterations).GetProgress() <autogenerated>:1 +0x85 go.k6.io/k6/cmd.getRunCmd.func1.1() /home/ivan/Projects/k6io/k6/cmd/run.go:180 +0x13d Also see #1863 (comment) .
mstoykov
approved these changes
Jun 16, 2021
na--
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling these methods defined on a value receiver copies the BaseExecutor instance and could cause a data race if another goroutine is writing to it. In practice this wasn't a problem and unlikely anyone would ever run into it on
master, but it did appear on thefeat/1320-execution-apibranch (#1863) when running:Clipped stack trace:
Also see #1863 (comment) .
(I didn't base this on
masteras I would need to rebase #1863 again and we all dislike the GH reference spam in issues 😅, and I would have to do this on #1863 anyway for the newly added methods.)