-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix array encoding in form data requests #2060
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 71.97% 71.91% -0.07%
==========================================
Files 181 179 -2
Lines 14139 14137 -2
==========================================
- Hits 10177 10167 -10
- Misses 3338 3343 +5
- Partials 624 627 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would've used a range
as it seems more idiomatic to me but this is fine as well
0d48122
to
c7bb596
Compare
Apparently 2 approvals are required if a previous approval was dismissed? :-/ |
This is a continuation of #1754, with an added check for the correct encoding and disabling of the
exhaustive
linter, since it doesn't seem like we can avoid the reflection.Closes #1713