Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array encoding in form data requests #2060

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Conversation

imiric
Copy link
Contributor

@imiric imiric commented Jun 11, 2021

This is a continuation of #1754, with an added check for the correct encoding and disabling of the exhaustive linter, since it doesn't seem like we can avoid the reflection.

Closes #1713

@imiric imiric requested review from mstoykov and na-- June 11, 2021 14:55
@imiric imiric added this to the v0.33.0 milestone Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #2060 (89a6da9) into master (5b44097) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 89a6da9 differs from pull request most recent head c7bb596. Consider uploading reports for the commit c7bb596 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
- Coverage   71.97%   71.91%   -0.07%     
==========================================
  Files         181      179       -2     
  Lines       14139    14137       -2     
==========================================
- Hits        10177    10167      -10     
- Misses       3338     3343       +5     
- Partials      624      627       +3     
Flag Coverage Δ
ubuntu 71.91% <100.00%> (+0.02%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/http/request.go 83.80% <100.00%> (+0.15%) ⬆️
js/common/initenv.go 66.66% <0.00%> (-33.34%) ⬇️
lib/netext/httpext/error_codes.go 94.52% <0.00%> (-2.74%) ⬇️
js/initcontext.go 90.42% <0.00%> (-2.13%) ⬇️
lib/netext/httpext/request.go 93.33% <0.00%> (-0.61%) ⬇️
js/runner.go 82.25% <0.00%> (-0.57%) ⬇️
lib/netext/httpext/error_codes_syscall_windows.go
cmd/ui_windows.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b44097...c7bb596. Read the comment docs.

na--
na-- previously approved these changes Jun 15, 2021
na--
na-- previously approved these changes Jun 15, 2021
mstoykov
mstoykov previously approved these changes Jun 15, 2021
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would've used a range as it seems more idiomatic to me but this is fine as well

@imiric imiric dismissed stale reviews from mstoykov and na-- via c7bb596 June 15, 2021 15:10
@imiric imiric force-pushed the fix/1713-params-array-encoding branch from 0d48122 to c7bb596 Compare June 15, 2021 15:10
@imiric imiric requested a review from na-- June 15, 2021 15:33
@imiric
Copy link
Contributor Author

imiric commented Jun 15, 2021

Apparently 2 approvals are required if a previous approval was dismissed? :-/

@imiric imiric merged commit 91bfc1c into master Jun 15, 2021
@imiric imiric deleted the fix/1713-params-array-encoding branch June 15, 2021 15:40
harrytwigg pushed a commit to APITeamLimited/globe-test that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples html_form_post.js fails
5 participants