Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jupyterlab/lumino
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @lumino/[email protected]
Choose a base ref
...
head repository: jupyterlab/lumino
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @lumino/[email protected]
Choose a head ref
  • 20 commits
  • 12 files changed
  • 4 contributors

Commits on Nov 17, 2020

  1. Add tab and tablist ARIA attributes for tabs.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    0f73321 View commit details
    Browse the repository at this point in the history

  2. Add tab aria attributes in constructor.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    67cfd6f View commit details
    Browse the repository at this point in the history

  3. Initial draft of adding tabpanel aria data for tabpanel and dockpanel.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    6ffad17 View commit details
    Browse the repository at this point in the history

  4. Add aria-label and aria-selected to tab bars.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    943e83e View commit details
    Browse the repository at this point in the history

  5. Remove aria-controls. 

    According to experts (including both an invited expert advisor and a co-chair of ARIA committee), aria-controls is not needed, and actually annoying in JAWS.
    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    7f39ac9 View commit details
    Browse the repository at this point in the history

  6. Add tab bar names, and default to “Activities <number>” for dockpanel. 

    Also use the tab bar orientation setter to set the default orientation.
    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    38a23b0 View commit details
    Browse the repository at this point in the history

  7. Keep application-specific things out of phosphor.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a902e8c View commit details
    Browse the repository at this point in the history

  8. Clean up tab panel adding widget ids and assuming tab bars are rendered.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    0d70003 View commit details
    Browse the repository at this point in the history

  9. Fix formatting and variable names for tabpanel

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    99e4fc4 View commit details
    Browse the repository at this point in the history

  10. Revert changes to default tab renderer and tab type parameters. 

    Before, we needed to clamp down on these types for aria attributes. This is (a) backwards incompatible and (b) not needed anymore.
    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    4605249 View commit details
    Browse the repository at this point in the history

  11. Add documentation for createTabKey.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    d7ddc19 View commit details
    Browse the repository at this point in the history

  12. Always set the aria attributes for a tab panel.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    8e68bcc View commit details
    Browse the repository at this point in the history

  13. Add two TODO notes about where the tab aria-selected state might need… 

    … to be updated.
    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    77a8017 View commit details
    Browse the repository at this point in the history

  14. Only create tab keys if we have a tab bar renderer.

    @jasongrout @telamonian
    jasongrout authored and telamonian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a6fdb77 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. add missing changelog entries

    @blink1073
    blink1073 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    dc18f19 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #152 from blink1073/fixup-changelog 

    Add missing changelog entries
    @Zsailer
    Zsailer authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    bdfa3cf View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Bump elliptic from 6.5.3 to 6.5.4 

    Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    9c31828 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #156 from jupyterlab/dependabot/npm_and_yarn/ellip… 

    …tic-6.5.4

Bump elliptic from 6.5.3 to 6.5.4
    @blink1073
    blink1073 authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    da8f700 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge pull request #132 from telamonian/aria-tabs-lumino-update 

    Add ARIA roles to tabs - lumino update
    @blink1073
    blink1073 authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e22c22f View commit details
    Browse the repository at this point in the history

  2. Publish 

     - @lumino/[email protected]
 - @lumino/[email protected]
 - @lumino/[email protected]
 - @lumino/[email protected]
 - @lumino/[email protected]
 - @lumino/[email protected]
 - @lumino/[email protected]
    @blink1073
    blink1073 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    ffcb871 View commit details
    Browse the repository at this point in the history
Loading