-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update ua-parser to recognize the Chromium-based Edge & Android 9 #319
Conversation
Reviewed the upgrade.
|
@Krinkle I don't have write access to this repository. Can you merge it if it looks fine for you? |
Yeah, once I get to that point I will merge it! (I don't have admin rights and thus also unable to grant it to you.) |
@Krinkle Can I update uap-php to 3.9.0? The |
That's fine sure. We can handle that at the same time. Note that this is still blocked on several other steps (per pull description). From a quick glance, it looks like upstream no longer has a working build on PHP 5.4. Which is fair for them (it's super EOL), but also what our server still runs. |
Is it enough for us that 3.8.8 had PHP 5.4 support and the code changes
between 3.8.8 and 3.9.0 are so minimal? Or do we need to update PHP first?
--
Michał Gołębiowski-Owczarek
|
The Regarding PHP and Composer, let's continue in private at https://github.com/jquery/infrastructure/issues/444. |
@Krinkle PR updated. I had to run |
@mgol It's normal to the extent that it reflects the change that ua-parser has undergone. Upstream removed several of its (allegedly unused) dependencies. |
@Krinkle It looks like the Chromium Edge may near a stable release so I had another look at it (as it's not clear when https://github.com/jquery/infrastructure/issues/449 gets resolved):
The diff between |
@Krinkle could you weigh in? The new Edge will arrive in less than a month. |
|
* Remove polyfills of php extensions we assume are installed (and indeed are installed in production). * Regenerate lock file and audit dependency changes. * Commit dependencies for ease of deployment and review. Ref #319.
Now deployed.
|
@Krinkle I rebased my PR and then:
What are the next steps here? Can I help with anything? |
This is needed to properly recognize: 1. the Chromium-based Edge which uses the "Edg/" token instead of "Edge/" 2. Android 9 which doesn't use a dot in its version in the user agent string
This is needed to properly recognize: