Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

asyncwrap: fix constructor condition for early ret #9146

Closed
wants to merge 1 commit into from
Closed

asyncwrap: fix constructor condition for early ret #9146

wants to merge 1 commit into from

Conversation

trevnorris
Copy link

AsyncWrap should always properly propagate asynchronous calls to any
child that is created. Regardless whether kCallInitHook is currently
active. The previous logic would always return early if kCallInitHook
wasn't set.

R=@tjfontaine

@misterdjules
Copy link

Adding to the 0.12.1 milestone as discussed.

AsyncWrap should always properly propagate asynchronous calls to any
child that is created. Regardless whether kCallInitHook is currently
active. The previous logic would always return early if kCallInitHook
wasn't set.
trevnorris added a commit that referenced this pull request Feb 9, 2015
AsyncWrap should always properly propagate asynchronous calls to any
child that is created. Regardless whether kCallInitHook is currently
active. The previous logic would always return early if kCallInitHook
wasn't set.

PR-URL: #9146
Reviewed-by: Julien Gilli <[email protected]>
@trevnorris
Copy link
Author

Landed on 605329d.

@trevnorris trevnorris closed this Feb 9, 2015
@trevnorris trevnorris deleted the fix-cond-asyncwrap branch February 9, 2015 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants