Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

build,win: set env before generating projects #20109

Closed
wants to merge 1 commit into from
Closed

build,win: set env before generating projects #20109

wants to merge 1 commit into from

Conversation

orangemocha
Copy link
Contributor

vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.
@orangemocha
Copy link
Contributor Author

@joyent/node-coreteam , ok to include this fix in 0.12.3?

@jasnell
Copy link
Member

jasnell commented Apr 23, 2015

LGTM

@misterdjules
Copy link

@orangemocha LGTM at first sight, testing right now.

@misterdjules
Copy link

Worked fine on my Windows 7 development setup. Thank you @orangemocha!

@misterdjules
Copy link

@orangemocha Feel free to land it using the node-accept-pull-request Jenkins job.

orangemocha added a commit that referenced this pull request Apr 23, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #20109
@orangemocha
Copy link
Contributor Author

Thanks guys! Landed in a58b174

rvagg pushed a commit to rvagg/io.js that referenced this pull request Jun 19, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
misterdjules pushed a commit to misterdjules/node that referenced this pull request Jun 24, 2015
Backport commit a58b174 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

  Reviewed-By: Julien Gilli <[email protected]>
  PR-URL: nodejs#20109

Conflicts:
	vcbuild.bat
misterdjules pushed a commit to misterdjules/node that referenced this pull request Jun 24, 2015
Backport commit a58b174 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

  Reviewed-By: Julien Gilli <[email protected]>
  PR-URL: nodejs#20109

Conflicts:
	vcbuild.bat
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jun 25, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jun 25, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
orangemocha added a commit to nodejs/node that referenced this pull request Jun 26, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
orangemocha added a commit to nodejs/node that referenced this pull request Jun 26, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jul 3, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs/node-v0.x-archive#20109
orangemocha added a commit to nodejs/node that referenced this pull request Jul 3, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <[email protected]>
PORT-PR-URL: #2101
PORT-FROM: c0c0d73
PR-URL: nodejs/node-v0.x-archive#20109
misterdjules pushed a commit to misterdjules/node that referenced this pull request Jul 21, 2015
Backport commit a58b174 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

  Reviewed-By: Julien Gilli <[email protected]>
  PR-URL: nodejs#20109

Conflicts:
	vcbuild.bat
misterdjules pushed a commit to misterdjules/node that referenced this pull request Jul 23, 2015
Backport commit a58b174 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

  Reviewed-By: Julien Gilli <[email protected]>
  PR-URL: nodejs#20109

Conflicts:
	vcbuild.bat
orangemocha added a commit that referenced this pull request Jul 23, 2015
Backport commit a58b174 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

  Reviewed-By: Julien Gilli <[email protected]>
  PR-URL: #20109

Conflicts:
	vcbuild.bat

Reviewed-By: João Reis <[email protected]>
PR-URL: #25569
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants