Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

debugger: don't spawn child process in remote mode #14172

Closed
wants to merge 2 commits into from
Closed

debugger: don't spawn child process in remote mode #14172

wants to merge 2 commits into from

Conversation

JacksonTian
Copy link

When debug in remote mode with host:port or pid, the interface
spawn child process also. If the debugger agent is running, will
get following output:

```
< Error: listen EADDRINUSE :::5858
<     at Object.exports._errnoException (util.js:734:11)
<     at exports._exceptionWithHostPort (util.js:757:20)
<     at Agent.Server._listen2 (net.js:1155:14)
<     at listen (net.js:1181:10)
<     at Agent.Server.listen (net.js:1268:5)
<     at Object.start (_debug_agent.js:21:9)
<     at startup (node.js:68:9)
<     at node.js:799:3
```

This fix won't spawn child process and no more error message was
shown.
@misterdjules
Copy link

LGTM, thank you @JacksonTian!

misterdjules pushed a commit that referenced this pull request Apr 14, 2015
Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #14172
misterdjules pushed a commit that referenced this pull request Apr 14, 2015
When debug in remote mode with host:port or pid, the interface
spawn child process also. If the debugger agent is running, will
get following output:

```
< Error: listen EADDRINUSE :::5858
<     at Object.exports._errnoException (util.js:734:11)
<     at exports._exceptionWithHostPort (util.js:757:20)
<     at Agent.Server._listen2 (net.js:1155:14)
<     at listen (net.js:1181:10)
<     at Agent.Server.listen (net.js:1268:5)
<     at Object.start (_debug_agent.js:21:9)
<     at startup (node.js:68:9)
<     at node.js:799:3
```

This fix won't spawn child process and no more error message was
shown.

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #14172
@misterdjules
Copy link

Landed in c63a39b and f0ef597. Thank you @JacksonTian!

@misterdjules misterdjules added this to the 0.12.3 milestone Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants