Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RgRaw returns fewer matches than the default function #9

Open
medwatt opened this issue Jul 22, 2020 · 4 comments
Open

RgRaw returns fewer matches than the default function #9

medwatt opened this issue Jul 22, 2020 · 4 comments

Comments

@medwatt
Copy link

medwatt commented Jul 22, 2020

Hello. I am using fzf.vim and did created a new command that allows the possibility of using rg to search a directory other than the current one. I was looking for ways to extend it so I can use options like -t when I stumbled upon your plugin. Thanks for this plugin; it seems to do the job. However, for some reason, I am getting few matches with your plugin than the one one I wrote (which is just a very simple modification I did to the default Rg plugin already part of fzf.vim). Can you probably say why this is so ?

Please see this image to see what I mean.

@jesseleite
Copy link
Owner

Thanks! I'm not sure. My plugin just extends fzf.vim's functions as well (most specifically the fzf#vim#grep() function). Might be something to do with the default rg flags being passed, which differs from the default flags being passed by your plugin?

@jesseleite
Copy link
Owner

Interesting it looks like fzf.vim's :Rg uses --smart-case by default, and mine doesn't.

@medwatt
Copy link
Author

medwatt commented Jul 22, 2020

Interesting it looks like fzf.vim's :Rg uses --smart-case by default, and mine doesn't.

You're right. I just checked. Including --smart-case with RgRaw returns the same count. Thank's for the plugin ones more.

@jesseleite
Copy link
Owner

I may change this default in my plugin. Not sure how --smart-case works with other case-related flags though. Will leave this open and look into it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants