-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal_012 aligned to wrong group #967
Comments
Morning @t-aras , I agree with your expected behavior. I will add the comment and blank line options seen in other alignment rules. Thanks, --Jeremy |
Good Afternoon @t-aras , I added the following two options to the rule: I pushed the update to the Thanks, --Jeremy |
Morning @t-aras , Just wanted to ping you on this issue to see if you had time to check it out. Thanks, --Jeremy |
Hey Jeremy Sorry, didn't had the time yet to test it. I am on vacation and will only be able to test it in the new year. Same for the other open issue with a fix ready: #998 I'll give you feedback as soon as I have tested it. |
Afternoon @t-aras , Wondering if you have time to check this out yet. Thanks, --Jeremy |
Morning @t-aras, Just a ping to see if you had a chance to check this out yet. I will plan to merge this to master by 2/18 if I do not here back from you. Thanks, --Jeremy |
Just tested it and it works fine on my end. Thank you for the fix! Best |
Awesome, I will get it merged to master. --Jeremy |
Environment
Version: 3.15.0
Linux
Describe the bug
The
signal_012
rule does align over all signal declarations. An empty line or a comment line does not end the group.Therefore the second in-line signal declarations is moved too far left.
To Reproduce
File to reproduce:
After running the fix for signal_012 the file looks like that:
Expected behavior
I would expect that the file should not be touched.
The text was updated successfully, but these errors were encountered: