feat(generator): support the same type for different themes #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
form-generator现在组件的配置是按照type分类的,如下:
以上按照type分类,存在以下问题:
考虑过的方案
用户配置的时候,保证type是唯一的。使用
theme:type
进行区分。缺点:
generator自动根据组件生成唯一值
缺点:
调研后,使用配置不一样的表单的场景比较少见且用户可以通过配置新的主题或组件来解决该问题。所以最终采用方案二
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
N
Related PRs
N