Merge pull request #6 from jdbence/fix/object-with-no-values

Allow object to have no values
jdbence · Dec 13, 2018 · c62e6bb · c62e6bb
2 parents 1c029fd + b0b0c9d
commit c62e6bb
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -7,7 +7,7 @@ jobs:
   build:
     docker:
       # specify the version you desire here
-      - image: circleci/node:7.10
+      - image: circleci/node:8.9.0
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v6.10
+v8.9.0
diff --git a/index.js b/index.js
@@ -12,7 +12,7 @@ export const FireStoreParser = value => {
     value = (value[prop].values || []).map(v => FireStoreParser(v))
   }
   else if (prop === 'mapValue') {
-    value = FireStoreParser(value[prop].fields)
+    value = FireStoreParser(value[prop].fields || {})
   }
   else if (prop === 'geoPointValue') {
     value = { latitude: 0, longitude: 0, ...value[prop] }

diff --git a/index.test.js b/index.test.js
@@ -169,6 +169,14 @@ test('Object match', () => {
   })).toEqual({ "obj": { "string": "def" } });
 });
 
+test('Object match with no values', () => {
+  expect(FireStoreParser({
+    "obj": {
+      "mapValue": {}
+    }
+  })).toEqual({ "obj": {} });
+});
+
 test('Array match', () => {
   expect(FireStoreParser({
     "array": {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "firestore-parser",
-  "version": "0.8.5",
+  "version": "0.8.6",
   "description": "Parse the Firestore REST API endpoint JSON into a useable JS object",
   "main": "./build/index.js",
   "scripts": {