From 534e8aae78f7443474c53121032141bc30f47d22 Mon Sep 17 00:00:00 2001
From: Steven Silvester <steven.silvester@ieee.org>
Date: Mon, 21 Nov 2022 06:44:21 -0600
Subject: [PATCH] more ci cleanup

---
 .github/workflows/check-release.yml | 22 ----------------------
 .github/workflows/downstream.yml    | 15 +++++++++++++++
 .github/workflows/tests.yml         |  4 +---
 README.md                           |  4 ++--
 4 files changed, 18 insertions(+), 27 deletions(-)
 delete mode 100644 .github/workflows/check-release.yml

diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
deleted file mode 100644
index 687f028d..00000000
--- a/.github/workflows/check-release.yml
+++ /dev/null
@@ -1,22 +0,0 @@
-name: Check Release
-on:
-  push:
-    branches: ["main"]
-  pull_request:
-    branches: ["*"]
-
-jobs:
-  check_release:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Base Setup
-        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
-      - name: Install Dependencies
-        run: |
-          pip install -e .
-      - name: Check Release
-        uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml
index 37776005..f9f41a94 100644
--- a/.github/workflows/downstream.yml
+++ b/.github/workflows/downstream.yml
@@ -62,3 +62,18 @@ jobs:
         with:
           package_name: notebook
           test_command: pytest -vv --ignore-glob=notebook/tests/selenium/* --ignore-glob=notebook/nbconvert/tests/* --ignore-glob=notebook/services/nbconvert/tests/*
+
+  downstream_check: # This job does nothing and is only used for the branch protection
+    if: always()
+    needs:
+      - notebook
+      - ipywidgets
+      - jupyter_server
+      - nbconvert
+      - ipython
+    runs-on: ubuntu-latest
+    steps:
+      - name: Decide whether the needed jobs succeeded or failed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 18c46668..1425de13 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -59,7 +59,6 @@ jobs:
           only_create_file: 1
       - name: Run the unit tests
         run: |
-          export PIP_CONSTRAINT="./contraints_file.txt"
           hatch run test:nowarn || hatch run test:nowarn --lf
 
   test_docs:
@@ -84,8 +83,7 @@ jobs:
           python_version: "3.11"
       - name: Run the tests
         run: |
-          export PIP_PRE=1
-          hatch run test:nowarn || hatch run test:nowarn --lf
+          PIP_PRE=1 hatch run test:nowarn || hatch run test:nowarn --lf
 
   make_sdist:
     name: Make SDist
diff --git a/README.md b/README.md
index ef7e6c42..4aab0774 100644
--- a/README.md
+++ b/README.md
@@ -1,9 +1,9 @@
 # Traitlets
 
 [![Tests](https://github.com/ipython/traitlets/actions/workflows/tests.yml/badge.svg)](https://github.com/ipython/traitlets/actions/workflows/tests.yml)
-[![Test downstream projects](https://github.com/ipython/traitlets/actions/workflows/downstream.yml/badge.svg)](https://github.com/ipython/traitlets/actions/workflows/downstream.yml)
 [![Documentation Status](https://readthedocs.org/projects/traitlets/badge/?version=latest)](https://traitlets.readthedocs.io/en/latest/?badge=latest)
-[![Tidelift](https://tidelift.com/subscription/pkg/pypi-traitlets)](https://tidelift.com/badges/package/pypi/traitlets?style=flat)
+[![codecov](https://codecov.io/gh/ipython/traitlets/branch/main/graph/badge.svg?token=HcsbLGEmI1)](https://codecov.io/gh/ipython/traitlets)
+[![Tidelift](https://tidelift.com/subscription/pkg/pypi-traitlets)](https://tidelift.com/badges/package/pypi/traitlets)
 
 |               |                                      |
 | ------------- | ------------------------------------ |