Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize and Tag all patterns #213

Closed
3 of 4 tasks
markusmo3 opened this issue Aug 15, 2015 · 6 comments
Closed
3 of 4 tasks

Categorize and Tag all patterns #213

markusmo3 opened this issue Aug 15, 2015 · 6 comments
Assignees
Milestone

Comments

@markusmo3
Copy link
Contributor

Due to splitting the issues up some information like the category got lost. And we have those cool new Tags.

All the index.md files of the patterns should get relevant categories and tags in the yaml frontmatter. The 'pattern_cat' and 'pattern_tag' stuff can be removed as it is only a placeholder...

The 'How to Contribute' Section of the README in master should explain everything that is needed for this issue.

EDIT:
After this point is done we should remove the pattern list from the master README file.

TODO:

  • Categorized all Patterns (done with adbb4ac)
  • Clarify Test if we can use proper casing instead of camel case as shown in adbb4ac. EDIT: I looked it up, it should work without "", e.g. just -> Creational Patterns
    (done with 5ce932c)
  • Tag all Patterns
    (partially done the with usage of tag "Java" instead of placeholder :P 5ce932c)
  • Remove pattern list from master README
    (done with 5ce932c)
@iluwatar
Copy link
Owner

Is there some limitation why we need to use snake casing e.g. presentation_tier? Can't we just type Presentation tier or maybe YAML need "Presentation tier".

@iluwatar
Copy link
Owner

What would be good tags to use? I'm thinking of implementation technologies e.g. Spring and Camel.

@markusmo3
Copy link
Contributor Author

Hmmm, to be honest im not too sure about beeing able to use proper casing with spaces. I'd say try it out and if it works then it definitly looks better than camel casing, right ?

And Tags, yeah. Maybe some things that differences this pattern from other ones. Like if its an EJB only pattern, JEE or JSE, ... The technologies used or similar to the pattern also sounds quite good. But i agree, this needs more clarification...

@npathai
Copy link
Contributor

npathai commented Aug 17, 2015

👍 Technologies can be tags for sure. Some other tags that I thought of are Functional, Persistence, I/O. But I am still figuring it out.

@iluwatar iluwatar modified the milestones: 2.0.0, 1.6.0 Aug 17, 2015
markusmo3 pushed a commit that referenced this issue Aug 20, 2015
- properly categorize all patterns
- remove pattern list from readme
- minor fixes to readme
- removed "introduction" because its not a pattern and an error i
committed some time ago
markusmo3 pushed a commit that referenced this issue Aug 20, 2015
- fixes #219 removed 2about.md and rename 1patterns.html to
patterns.html
- fixes #217 changed forkme banner to more intuitive github-buttons
- Work on #213 properly name all the categories, fix issue with spaces
in categories and tags
@iluwatar iluwatar modified the milestones: 1.7.0, 1.6.0 Aug 31, 2015
@npathai
Copy link
Contributor

npathai commented Sep 16, 2015

We need to tag based on difficulty as well.

npathai added a commit that referenced this issue Sep 22, 2015
…rns, added tag for Gang Of Four, added difficulty tags to some of them
@iluwatar iluwatar modified the milestones: 1.8.0, 1.7.0 Sep 30, 2015
@iluwatar iluwatar modified the milestones: 1.9.0, 1.8.0 Dec 2, 2015
iluwatar added a commit that referenced this issue Dec 28, 2015
@iluwatar iluwatar self-assigned this Dec 28, 2015
iluwatar added a commit that referenced this issue Dec 28, 2015
iluwatar added a commit that referenced this issue Dec 28, 2015
@iluwatar
Copy link
Owner

I did the categorization and tagging of the patterns today. The used categories and tags can be seen here.

iluwatar added a commit that referenced this issue Dec 28, 2015
pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this issue Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants