-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new brightness handling #430
Conversation
- update webserver, now with initial ssl support
I like what you did with the brightness. I have some questions:
Btw I would have preferred if you had separated the brightness changes and the webserver changes in different PRs. Would have been easier to read ;) |
perfect so far, i didn't found weirdness. I wonder if you want to move the backlightThreshold to Integer too (for the visual touch :)) |
The maping of config value is not linear because it feels better. I tried that 50% is half brightness |
thats a good idea, will modify the code tomorow |
- better performance for brightness - use piecewise linear instead of sqrt
1. Tell us something about your changes.
this is a result of lot's of discussions. The new brightness stuff is based on @Funatiq new color correction. Setting the brightness modifies the values for color correction. This will limit the brightness of each color component. The new option "brightnessCompensation" handles the problem that e.g. white (255,255,255)has 3 times more energy than red (255,0,0).
additional: updatewebserver, now with initial ssl support
2. If this changes affect the .conf file. Please provide the changed section
3. Reference an issue (optional)
#422
Note: For further discussions use our forum: forum.hyperion-project.org