Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pac-Man effect #382

Merged
merged 1 commit into from
Feb 8, 2017
Merged

add Pac-Man effect #382

merged 1 commit into from
Feb 8, 2017

Conversation

7h30n3
Copy link
Contributor

@7h30n3 7h30n3 commented Feb 5, 2017

1. Tell us something about your changes.
Just adding a new effect.

2. If this changes affect the .conf file. Please provide the changed section

3. Reference an issue (optional)

Note: For further discussions use our forum: forum.hyperion-project.org

@redPanther
Copy link
Contributor

thx! can you add a json schema file. This is located in effects/schema. This file is needed for the effect configurator and json validation

@brindosch
Copy link
Contributor

Sounds funny, thank you!
As i respect your efforts i won't miss the moment and want to ask you if you may be interested in porting this one :)
https://github.com/FastLED/FastLED/blob/master/examples/Fire2012/Fire2012.ino

Would be great :)

@7h30n3
Copy link
Contributor Author

7h30n3 commented Feb 6, 2017

Is there a guideline for the json schema? The pac-man effect hasn't any changeable properties, so is "required" still "true" and can I leave out "properties" at all or do I have to write "properties":{}, ?

@brindosch I don't know if the Fire2012-Effect is suitable or easily applicable for LEDs in a square arrangement (behind a display).

@Paulchen-Panther
Copy link
Member

@brindosch @7h30n3
Try this. fire2012

P.S.: Ist nur eine Testversion. Ist noch ziemlich CPU Hungrig. Und die Richtung der Flamme könnte auch von unten nach oben geändert werden.

@brindosch
Copy link
Contributor

I didn't know you did it!
Cool! Yes, some options are never bad which controls the direction or limit it to left/right only /brightness colors/ whatever :) (like seen in knight rider)

@brindosch
Copy link
Contributor

@7h30n3
I added the effect schema to my current pr. No further actions required :)
I you have some more effect ideas, feel free to PR them :)

Thank you!

@brindosch brindosch merged commit 86814eb into hyperion-project:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants