Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio(all): introduce functional options #1039

Merged
merged 1 commit into from
Nov 23, 2023
Merged

aio(all): introduce functional options #1039

merged 1 commit into from
Nov 23, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 23, 2023 •
edited
Loading

Solved issues and/or description of the change

#999

additionally:

  • improve aio tests and fix some minor bugs regarding to names of grove drivers
  • adjust examples according to new behavior
  • adjust YL40 driver according to new behavior
  • make some small cosmetic changes in unreleated tests

Manual test

  • OS and Version (Win/Mac/Linux): tinkerboard
  • Adaptor(s) and/or driver(s): YL40 ADC/DAC

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 23, 2023 18:01
@gen2thomas gen2thomas merged commit 3980845 into hybridgroup:dev Nov 23, 2023
2 checks passed
@gen2thomas gen2thomas deleted the feature/aio_variadic branch November 23, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas