Merge pull request asynkron#327 from yangdiangzb/fix-typos-and-redund…

…ant-stuff

fix typos, remove redundant import alias, type, and whitespaces.

actor/actor_context.go

@@ -244,7 +244,7 @@ func (ctx *actorContext) AwaitFuture(f *Future, cont func(res interface{}, err e
 	message := ctx.messageOrEnvelope
 	// invoke the callback when the future completes
 	f.continueWith(func(res interface{}, err error) {
-		// send the wrapped callaback as a continuation message to self
+		// send the wrapped callback as a continuation message to self
 		ctx.self.sendSystemMessage(&continuation{
 			f:       wrapper,
 			message: message,
@@ -354,7 +354,7 @@ func (ctx *actorContext) SpawnPrefix(props *Props, prefix string) *PID {
 
 func (ctx *actorContext) SpawnNamed(props *Props, name string) (*PID, error) {
 	if props.guardianStrategy != nil {
-		panic(errors.New("Props used to spawn child cannot have GuardianStrategy"))
+		panic(errors.New("props used to spawn child cannot have GuardianStrategy"))
 	}
 
 	var pid *PID

actor/actor_context_test.go

@@ -48,8 +48,8 @@ func TestActorContext_Stop(t *testing.T) {
 	o.AssertExpectations(t)
 }
 
-func TestActorContext_SendMessage_WithSenderdMiddleware(t *testing.T) {
-	// Define a local context with no-op sender middlware
+func TestActorContext_SendMessage_WithSenderMiddleware(t *testing.T) {
+	// Define a local context with no-op sender middleware
 	mw := func(next SenderFunc) SenderFunc {
 		return func(ctx SenderContext, target *PID, envelope *MessageEnvelope) {
 			next(ctx, target, envelope)
@@ -144,7 +144,6 @@ func TestActorContext_Respond(t *testing.T) {
 }
 
 func TestActorContext_Forward(t *testing.T) {
-
 	// Defined a respond actor
 	// It simply respond the string message
 	responder := rootContext.Spawn(PropsFromFunc(func(ctx Context) {
@@ -193,15 +192,15 @@ func BenchmarkActorContext_ProcessMessageWithMiddleware(b *testing.B) {
 }
 
 func benchmarkActorContext_SpawnWithMiddlewareN(n int, b *testing.B) {
-	middlwareFn := func(next SenderFunc) SenderFunc {
+	middlewareFn := func(next SenderFunc) SenderFunc {
 		return func(ctx SenderContext, pid *PID, env *MessageEnvelope) {
 			next(ctx, pid, env)
 		}
 	}
 
 	props := PropsFromProducer(nullProducer)
 	for i := 0; i < n; i++ {
-		props = props.WithSenderMiddleware(middlwareFn)
+		props = props.WithSenderMiddleware(middlewareFn)
 	}
 
 	parent := &actorContext{self: NewLocalPID("foo"), props: props}

actor/actor_example_test.go

@@ -10,8 +10,8 @@ import (
 
 // Demonstrates how to create an actor using a function literal and how to send a message asynchronously
 func Example() {
-	var context *actor.RootContext = actor.EmptyRootContext
-	var props *actor.Props = actor.PropsFromFunc(func(c actor.Context) {
+	var context = actor.EmptyRootContext
+	var props = actor.PropsFromFunc(func(c actor.Context) {
 		if msg, ok := c.Message().(string); ok {
 			fmt.Println(msg) // outputs "Hello World"
 		}

actor/child_test.go

@@ -66,7 +66,6 @@ func NewCreateChildThenStopActor() Actor {
 }
 
 func TestActorCanStopChildren(t *testing.T) {
-
 	actor := rootContext.Spawn(PropsFromProducer(NewCreateChildThenStopActor))
 	count := 10
 	for i := 0; i < count; i++ {

actor/guardian.go

@@ -42,7 +42,7 @@ type guardianProcess struct {
 }
 
 func (g *guardianProcess) SendUserMessage(pid *PID, message interface{}) {
-	panic(errors.New("Guardian actor cannot receive any user messages"))
+	panic(errors.New("guardian actor cannot receive any user messages"))
 }
 
 func (g *guardianProcess) SendSystemMessage(pid *PID, message interface{}) {
@@ -56,11 +56,11 @@ func (g *guardianProcess) Stop(pid *PID) {
 }
 
 func (g *guardianProcess) Children() []*PID {
-	panic(errors.New("Guardian does not hold its children PIDs"))
+	panic(errors.New("guardian does not hold its children PIDs"))
 }
 
 func (*guardianProcess) EscalateFailure(reason interface{}, message interface{}) {
-	panic(errors.New("Guardian cannot escalate failure"))
+	panic(errors.New("guardian cannot escalate failure"))
 }
 
 func (*guardianProcess) RestartChildren(pids ...*PID) {

actor/messages.go

@@ -2,7 +2,7 @@ package actor
 
 import "github.com/AsynkronIT/protoactor-go/mailbox"
 
-// An AutoReceiveMessage is a special kind of user message that will be handled in some way automatially by the actor
+// An AutoReceiveMessage is a special kind of user message that will be handled in some way automatically by the actor
 type AutoReceiveMessage interface {
 	AutoReceiveMessage()
 }

actor/middleware/opentracing/sendermiddleware.go

@@ -7,10 +7,8 @@ import (
 )
 
 func SenderMiddleware() actor.SenderMiddleware {
-
 	return func(next actor.SenderFunc) actor.SenderFunc {
 		return func(c actor.SenderContext, target *actor.PID, envelope *actor.MessageEnvelope) {
-
 			span := getActiveSpan(c.Self())
 
 			if span == nil {

actor/middleware/propagator/middlewarepropagation_test.go

@@ -9,7 +9,6 @@ import (
 )
 
 func TestPropagator(t *testing.T) {
-
 	mutex := &sync.Mutex{}
 	spawningCounter := 0
 

actor/props.go

@@ -142,7 +142,7 @@ func (props *Props) WithSupervisor(supervisor SupervisorStrategy) *Props {
 	return props
 }
 
-// Assign one or more middlewares to the props
+// Assign one or more middleware to the props
 func (props *Props) WithReceiverMiddleware(middleware ...ReceiverMiddleware) *Props {
 	props.receiverMiddleware = append(props.receiverMiddleware, middleware...)
 

actor/strategy_all_for_one.go

@@ -52,7 +52,6 @@ func (strategy *allForOneStrategy) HandleFailure(supervisor Supervisor, child *P
 }
 
 func (strategy *allForOneStrategy) shouldStop(rs *RestartStatistics) bool {
-
 	// supervisor says this child may not restart
 	if strategy.maxNrOfRetries == 0 {
 		return true

actor/strategy_one_for_one.go

@@ -50,7 +50,6 @@ func (strategy *oneForOne) HandleFailure(supervisor Supervisor, child *PID, rs *
 }
 
 func (strategy *oneForOne) shouldStop(rs *RestartStatistics) bool {
-
 	// supervisor says this child may not restart
 	if strategy.maxNrOfRetries == 0 {
 		return true

actor/supervision_test.go

@@ -72,7 +72,6 @@ func (e *Expector) ExpectMsg(expected interface{}, t *testing.T) {
 }
 
 func (e *Expector) ExpectNoMsg(t *testing.T) {
-
 	select {
 	case actual := <-e.C:
 		at := reflect.TypeOf(actual)
@@ -82,7 +81,7 @@ func (e *Expector) ExpectNoMsg(t *testing.T) {
 	}
 }
 
-func TestActorStopsAfterXRestars(t *testing.T) {
+func TestActorStopsAfterXRestarts(t *testing.T) {
 	m, e := NewObserver()
 	props := PropsFromProducer(func() Actor { return &failingChildActor{} }).WithReceiverMiddleware(m)
 	child := rootContext.Spawn(props)

cli/main.go

@@ -14,7 +14,7 @@ import (
 
 	"github.com/AsynkronIT/protoactor-go/actor"
 	"github.com/AsynkronIT/protoactor-go/remote"
-	proto "github.com/gogo/protobuf/proto"
+	"github.com/gogo/protobuf/proto"
 )
 
 // Reference imports to suppress errors if they are not otherwise used.
@@ -106,6 +106,7 @@ func main() {
 	}
 exit:
 }
+
 func spawnEcho() {
 	echoPID, _ = rootContext.SpawnNamed(actor.PropsFromFunc(func(ctx actor.Context) {
 		switch msg := ctx.Message().(type) {
@@ -122,6 +123,7 @@ func spawnEcho() {
 
 	}), "echo")
 }
+
 func watch(line string) {
 	parts := strings.SplitN(line, " ", 2)
 
@@ -139,6 +141,7 @@ func watch(line string) {
 		})
 	}
 }
+
 func tell(line string) {
 	parts := strings.SplitN(line, " ", 4)
 

cluster/cluster.go

@@ -11,7 +11,7 @@ import (
 
 var cfg *ClusterConfig
 
-var rootContext *actor.RootContext = actor.EmptyRootContext
+var rootContext = actor.EmptyRootContext
 
 func Start(clusterName, address string, provider ClusterProvider) {
 	StartWithConfig(NewClusterConfig(clusterName, address, provider))

cluster/consul/consul_provider.go

@@ -189,7 +189,6 @@ func (p *ConsulProvider) deregisterService() error {
 }
 
 func (p *ConsulProvider) registerMember() error {
-
 	txn := api.KVTxnOps{}
 
 	// register a unique ID for the current process
@@ -227,7 +226,6 @@ func (p *ConsulProvider) blockingStatusChange() {
 }
 
 func (p *ConsulProvider) notifyStatuses() {
-
 	statuses, meta, err := p.client.Health().Service(p.clusterName, "", false, &api.QueryOptions{
 		WaitIndex: p.index,
 		WaitTime:  p.blockingWaitTime,
@@ -272,14 +270,13 @@ func (p *ConsulProvider) notifyStatuses() {
 	}
 	// the reason why we want this in a batch and not as individual messages is that
 	// if we have an atomic batch, we can calculate what nodes have left the cluster
-	// passing events one by one, we can't know if someone left or just havent changed status for a long time
+	// passing events one by one, we can't know if someone left or just haven't changed status for a long time
 
 	// publish the current cluster topology onto the event stream
 	eventstream.Publish(res)
 }
 
 func (p *ConsulProvider) MonitorMemberStatusChanges() {
-
 	go func() {
 		for !p.shutdown {
 			p.notifyStatuses()

cluster/member_list.go

@@ -79,7 +79,6 @@ func (ml *memberListValue) getActivatorMember(kind string) string {
 }
 
 func (ml *memberListValue) updateClusterTopology(m interface{}) {
-
 	ml.mutex.Lock()
 	defer ml.mutex.Unlock()
 
@@ -108,7 +107,6 @@ func (ml *memberListValue) updateClusterTopology(m interface{}) {
 }
 
 func (ml *memberListValue) updateAndNotify(new *MemberStatus, old *MemberStatus) {
-
 	if new == nil && old == nil {
 		// ignore, not possible
 		return

cluster/partition.go

@@ -213,7 +213,6 @@ func (state *partitionActor) terminated(msg *actor.Terminated) {
 }
 
 func (state *partitionActor) memberRejoined(msg *MemberRejoinedEvent, context actor.Context) {
-
 	memberAddress := msg.Name()
 
 	plog.Info("Member rejoined", log.String("kind", state.kind), log.String("name", memberAddress))
@@ -236,7 +235,6 @@ func (state *partitionActor) memberRejoined(msg *MemberRejoinedEvent, context ac
 }
 
 func (state *partitionActor) memberLeft(msg *MemberLeftEvent, context actor.Context) {
-
 	memberAddress := msg.Name()
 
 	plog.Info("Member left", log.String("kind", state.kind), log.String("name", memberAddress))
@@ -291,7 +289,7 @@ func (state *partitionActor) transferOwnership(actorID string, address string, c
 		Pid:  pid,
 		Name: actorID,
 	})
-	// we can safely delete this entry as the consisntent hash no longer points to us
+	// we can safely delete this entry as the consistent hash no longer points to us
 	delete(state.partition, actorID)
 	delete(state.keyNameMap, pid.String())
 	context.Unwatch(pid)

cluster/rendezvous.go

@@ -22,7 +22,6 @@ func NewRendezvous(memberStrategy MemberStrategy) *Rendezvous {
 // Get returns the node with the highest score for the given key. If this Hash
 // has no nodes, an empty string is returned.
 func (r *Rendezvous) GetByRdv(key string) string {
-
 	members := r.m.GetAllMembers()
 	l := len(members)
 

cluster/weighted/weighted_round_robin.go

@@ -20,7 +20,6 @@ func NewWeightedRoundRobin(memberStrategy cluster.MemberStrategy) *WeightedRound
 }
 
 func (r *WeightedRoundRobin) GetByRoundRobin() string {
-
 	members := r.m.GetAllMembers()
 	l := len(members)
 

cluster/weighted/weighted_round_robin_test.go

@@ -5,7 +5,6 @@ import "testing"
 var wrr = NewWeightedRoundRobin(nil)
 
 func BenchmarkGCD40(b *testing.B) {
-
 	val := []int{4, 4, 8, 6, 12, 30, 50, 150, 124, 124, 52, 66, 68, 168, 190, 244, 690, 400, 120, 520, 4, 4, 8, 6, 12, 30, 50, 150, 124, 124, 52, 66, 68, 168, 190, 244, 690, 400, 120, 520}
 
 	for n := 0; n < b.N; n++ {
@@ -14,7 +13,6 @@ func BenchmarkGCD40(b *testing.B) {
 }
 
 func BenchmarkGCD20(b *testing.B) {
-
 	val := []int{4, 4, 8, 6, 12, 30, 50, 150, 124, 124, 52, 66, 68, 168, 190, 244, 690, 400, 120, 520}
 
 	for n := 0; n < b.N; n++ {
@@ -23,7 +21,6 @@ func BenchmarkGCD20(b *testing.B) {
 }
 
 func BenchmarkGCD2(b *testing.B) {
-
 	val := []int{4, 520}
 
 	for n := 0; n < b.N; n++ {

examples/cluster-metrics/member/main.go

@@ -14,10 +14,6 @@ import (
 	"github.com/AsynkronIT/protoactor-go/remote"
 )
 
-const (
-	timeout = 1 * time.Second
-)
-
 // Logger is message middleware which logs messages before continuing to the next middleware
 func Logger(next actor.ReceiverFunc) actor.ReceiverFunc {
 	fn := func(context actor.ReceiverContext, env *actor.MessageEnvelope) {

examples/cluster-metrics/seed/main.go

@@ -26,7 +26,6 @@ func Logger(next actor.ReceiverFunc) actor.ReceiverFunc {
 }
 
 func main() {
-
 	// this node knows about Hello kind
 	remote.Register("Hello", actor.PropsFromProducer(func() actor.Actor {
 		return &shared.HelloActor{}

examples/cluster/member/main.go

@@ -13,10 +13,6 @@ import (
 	"github.com/AsynkronIT/protoactor-go/remote"
 )
 
-const (
-	timeout = 1 * time.Second
-)
-
 func main() {
 	// this node knows about Hello kind
 	remote.Register("Hello", actor.PropsFromProducer(func() actor.Actor {

examples/cluster/seed/main.go

@@ -12,7 +12,6 @@ import (
 )
 
 func main() {
-
 	// this node knows about Hello kind
 	remote.Register("Hello", actor.PropsFromProducer(func() actor.Actor {
 		return &shared.HelloActor{}

examples/inprocessbenchmark/main.go

@@ -23,8 +23,6 @@ type Start struct {
 	Sender *actor.PID
 }
 
-// type Started struct{}
-
 type pingActor struct {
 	count        int
 	wgStop       *sync.WaitGroup

examples/receivetimeout/main.go

@@ -14,8 +14,7 @@ type NoInfluence string
 func (NoInfluence) NotInfluenceReceiveTimeout() {}
 
 func main() {
-
-	log.Println("Reveive timeout test")
+	log.Println("Receive timeout test")
 
 	c := 0
 

examples/remoteheader/node1/main.go

@@ -11,7 +11,6 @@ import (
 )
 
 func main() {
-
 	remote.Start("127.0.0.1:8081")
 
 	rootContext := actor.EmptyRootContext

examples/remoterouting/server/main.go

@@ -52,7 +52,6 @@ func newRemote(bind, name string) {
 }
 
 func main() {
-
 	runtime.GOMAXPROCS(runtime.NumCPU())
 	runtime.GC()