Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loftq_utils.py depdends on huggingface_hub.errors, which doesn't appear in some versions of huggingface_hub #2097

Open
2 of 4 tasks
mashoutsider opened this issue Sep 25, 2024 · 1 comment

Comments

@mashoutsider
Copy link

System Info

loftq_utils.py refers to huggingface_hub.errors

Should the requirements.txt include huggingface_hub?

I have huggingface_hub version 0.19.4 and it does not have huggingface_hub.errors.

Is there a workaround or another version of huggingface_hub?

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder
  • My own task or dataset (give details below)

Reproduction

Should the requirements.txt include huggingface_hub?

I have huggingface_hub version 0.19.4 and it does not have huggingface_hub.errors.

Is there a workaround or another version of huggingface_hub?

Expected behavior

Should the requirements.txt include huggingface_hub?

I have huggingface_hub version 0.19.4 and it does not have huggingface_hub.errors.

Is there a workaround or another version of huggingface_hub?

@BenjaminBossan
Copy link
Member

It's true that we don't explicitly list huggingface_hub as a requirement, but it's an indirect requirement (e.g. it's a requirement of accelerate which is a requirement of PEFT). For your specific problem, I think it can easily be solved if the error is imported from huggingface_hub.utils instead. I tested this locally with v0.19.4 and it worked. Would you like to create a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants