Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to the old way of fitting into 16:9: Crop one line at the top and bottom #18704

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

hrydgard
Copy link
Owner

I seem to have switched to a stretch at some point, which isn't ideal and can be achieved anyway with the existing stretch option. A two-line crop (1 at top, 1 at bottom) is generally the better option and preserves the correct aspect ratio.

There's now also a hidden ini setting to turn it off. I might be convinced to add it as a real setting once I figure out a good name for it. The setting:

[Graphics]
DisplayCropTo16x9 = True

Fixes #18693

… top and bottom

I seem to have switched to a stretch at some point, which isn't ideal and can be
achieved anyway with the stretch option. A two-line crop (1 at top, 1 at bottom)
is generally the better option.

There's now also a hidden ini setting to turn it off. I might be
convinced to add it as a real setting once I figure out a good name for
it. The setting:

```ini
[Graphics]
DisplayCrop16x9 = True
```

Fixes #18693
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jan 15, 2024
@hrydgard hrydgard added this to the v1.17.0 milestone Jan 15, 2024
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jan 15, 2024
@hrydgard hrydgard merged commit 98c061f into master Jan 15, 2024
18 checks passed
@hrydgard hrydgard deleted the fix-crop-to-16x9 branch January 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a toggle to preserve fullscreen aspect ratio in "Display Layout & effects"
1 participant