softgpu: Ensure early depth test uses SIMD #17621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For an independent 5% improvement, definitely seems worth the added complexity. |
hrydgard
approved these changes
Jun 25, 2023
5 tasks
|
This is reported to crash in Crazy Taxi, I guess memory slightly out of bounds.. |
|
Hm, if the crash started with this, I guess it'd have to be alignment? Or actually, these don't have alignment requirements. It would've crashed before too if x/y went outside VRAM. Which shouldn't really happen here, since the render target ought to be masked to the first 2MB anyway. But also the alignment ought to be safe because the render target should mask that too. Seems there's a frame dump, will see if I have some time to look... -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit unfortunate to split this out of the main depth test func as it adds ~100 lines, but this seems to improve FPS for me in software rendering by around 5% (depending on game) in 3D games, so seems worth it.
-[Unknown]