Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to present from little temp framebuffers used by Godfather to draw text #17298

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Apr 17, 2023

Helps #16915, but the text is kinda hard to read, which is probably a separate issue.

The framebuffer does contain the top of the video frame at the present time though, so things have partially gone well. However the rest of the video frame lies after it in VRAM, while also overlapping it. What we probably technically should do when we see this is to assemble an image from both the framebuffer we find and VRAM contents exceeding the range of that image, but seems kinda impractical.

This works, but as mentioned there seems to be some other issue with how the text is rendered or copied. Could be a color precision issue confusing the game I suppose.

Savestate for repro (ppdmp useless in this case):
GodfatherSubtitles.zip

…to draw text.

The framebuffer does contain the top of the video frame at the present
time though, so things have partially gone well. However the rest of the
frame lies after it in VRAM. What we probably technically should do when
we see this is to assemble an image from both the framebuffer we find
and VRAM contents exceeding the range of that image, but seems kinda
impractical.

This works, but there seems to be some other issue with how the text is
rendered or copied. Could be a color precision issue confusing the game
I suppose.
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Apr 17, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Apr 17, 2023
@hrydgard
Copy link
Owner Author

This is an improvement so I'll get it in, even though we still have more issues in #16915.

@hrydgard hrydgard merged commit 3f4c01a into master Apr 18, 2023
@hrydgard hrydgard deleted the godfather-present-workaround branch April 18, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant