softgpu: Fix over-optimization of alpha test #17214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to output to the collected output for it to actually show as a failure.
Of course it doesn't matter when optimizations are enabled in any compiler that can build PPSSPP...
When alpha blend is off, was previously skipping the alpha test if only it was enabled. See hrydgard#17213.
hrydgard
approved these changes
Apr 1, 2023
fengjixuchui
added a commit
to fengjixuchui/ppsspp
that referenced
this pull request
Apr 1, 2023
Merge pull request hrydgard#17214 from unknownbrackets/softgpu-alpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously only allowing the fast path with alpha blend on, surprised we didn't notice this earlier after it was changed to allow no blending. Fixes #17213.
Also turns out headless was not failing properly when the compare didn't match (broke some of my scripts.)
-[Unknown]