Correct some reversed dependencies, minor other cleanup #16662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was in the wrong header file, which was a bit confusing.
Particularly in Common, avoid including Core/Reporting.h.
unknownbrackets
added
the
Code Cleanup
hrydgard
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some small issues while poking at another problem, and figured I'd drop some cleanup here.
This fixes several cases of Core being referenced by Common, which I'd like to avoid. There's still some left in Common/VR/, but that code is changing more often and I didn't want to break it anyway.
Also some small header cleanups and a few duplicate pathnames in CMakeLists.txt.
Oops, "tiny reverse dependency" was meant to be "tint", but I suppose it works just as well.
-[Unknown]