softgpu: Handle infnan fog coefficients better #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the GE debugger and CPU debugger, it's annoying sometimes to express everything in hex. This allows using an i or u prefix to get decimal.
This way you can break when a register is changed and prim count is in a certain range, which can be convenient.
If we ended up with a dot product that had opposing inf signs, the add would result in NAN and cause problems.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the sky in Outrun, which was broken by my optimization to use a dot for the fog constant. See #11380 for the correct behavior, and #16131 for the frame dump.
Also slip in some debugger improvements I added while checking that.
-[Unknown]