Always skin in decode for software transform and rendering #16347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meanwhile, move to a flag on decoder options instead of global check.
There's only software skinning, after all.
unknownbrackets
added
the
Code Cleanup
|
Oh, I didn't see #16345. Hm, well, we can just remove it. This is a half-step. -[Unknown] |
|
If we decide not to do #16345, I'm happy to merge this. Additionally I'll pull out the binding refactoring. |
|
I'm just gonna get this in, I can rebase #16345 on top later if we decide to go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't remove hardware skinning, but it makes the option apply only to hardware skinning - and enforces a single path of software skinning for software transform, bounding box, and software rendering.
This actually fixes a bug when software skinning was off and bounding box was used with skinning (unlikely usage, though.)
-[Unknown]